Closed vlamai closed 5 years ago
Great work @kzoper
I will look at this next weekend. However, my current thinking is changing the import
package into io
and having your functions inside that package rather than trying to replicate the pandas library function for function.
The reason why I am leaning that way is that the core functionality should be kept separate from enhancement functionality. Some users won't be using these import/export features so by including them in the main package will just increase the binary. Go files are already quite large.
What's the exact error you get when tests fail?
Is there any news on this CSV/JSON in/out?
I just found out the unexpected panic
on the empty function body here: https://github.com/rocketlaunchr/dataframe-go/blob/master/imports/imports.go#L76
That's useless so I am wondering if there is any plan to merge/harmonize the code in here?
Thanks
I guess it card be too hard to implement a json import. I'll give it a try within a month.
It will have to use the json Decoder instead of unmarshaler however.
@tappoz json importing has been implemented. Check the json-imports
branch to give me feedback before I merge it to master.
importing and exporting functionality has now been added.
function works. But tests fails, i don't know why
JSON import works only with
[][]string
file structure