search

rocketlaunchr / dataframe-go

DataFrames for Go: For statistics, machine-learning, and data manipulation/exploration
Other
1.16k stars 93 forks source link

Progress for re-write of dataframe-go? #67

Open winston-p opened 2 years ago

winston-p commented 2 years ago

It's written in the README file that "Once Go 1.18 (Generics) is introduced, the ENTIRE package will be rewritten.", As Go 1.18 has been released for a while, I'm wondering if work has started on re-writing of the entire package. If so, how's the progress?

pjebs commented 2 years ago

I'm still thinking about the best way to rewrite it. Looking for suggestions and help

winston-p commented 2 years ago

I see. Perhaps you could detail some of your thoughts and ideas so far? I'm fairly new to Go but I'm sure others more experienced than me can chime in and/or offer help.

pjebs commented 2 years ago

Do you want to have a zoom chat?

amlwwalker commented 1 year ago

Would love to see this working with generics (and possibly be able to import a python pandas dataframe would be excellent). Happy to be involved to help with any thought process as this will be a game changer for Go!

pjebs commented 1 year ago

@amlwwalker Let me know if you want to help. My vision for how to add generics came undone when I learnt that you can't have generic methods: You can have generic functions obviously. But for some reason no generic methods.

amlwwalker commented 1 year ago

@pjebs does this not work? https://stackoverflow.com/a/70668559/1414721

can you give an example of a situation where that wouldn't cover the use case?

pjebs commented 1 year ago 
type x struct {

}

func (s *x)[X any, Y any, D any] MyFunc(a X, b Y) D { // not allowed

}
amlwwalker commented 1 year ago

Does this not help? https://stackoverflow.com/a/71378366/1414721

So each struct will need the method available on it, (could that be generated?) but you can then use an interface?

pjebs commented 1 year ago

Do you want to discuss over Zoom?

amlwwalker commented 1 year ago

happy to - I'm not very familiar with Go generics so I am probably not so useful to you, but if you want to talk it through with someone happy to be a sounding board. Got to get some stuff done right now, but can plan?

pjebs commented 1 year ago

send me an email with your availability: rocketlaunchr.cloud@gmail.com

agaddis02 commented 9 months ago

wanted to ping this thread again @pjebs are you still working on a rewrite?

SaikyoSaru commented 7 months ago

Bump on the above @pjebs, I would like to help out if you need a hand :)

rocketlaunchr-cto commented 7 months ago

Id love help. Let me know when your area few for a video chat.

On Thu, 22 Feb 2024, 04:31 SaikyoSaru, @.***> wrote:

On up on the above @pjebs https://github.com/pjebs, I would like to help out if you need a hand :)

— Reply to this email directly, view it on GitHub https://github.com/rocketlaunchr/dataframe-go/issues/67#issuecomment-1957412872, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFKWTGPC4EL3OQFYB2SBN3YUYVNVAVCNFSM6AAAAAAQH2XS5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJXGQYTEOBXGI . You are receiving this because you are subscribed to this thread.Message ID: @.***>