search

rocketmail / jfxflow

Automatically exported from code.google.com/p/jfxflow
0 stars 0 forks source link

Interface instead of abstract class in FxmlLoader #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Hi,

in class FxmlLoader you check in line 66 for the abstract class 
"AbstractActivity". I think it would be great if you could do it by interface, 
so people can write their own controller and do not have to derive from your 
AbstractActivity class (what I did, but does not work there, since it checks 
for an implementation already).

Cheers, Rob.

P.S. Great work so far, looks promising. I like the idea and playing around 
with it ;-).

Original issue reported on code.google.com by robert.w...@web.de on 29 Nov 2011 at 1:40

GoogleCodeExporter commented 8 years ago 
It shows type: Defect.
Its def not a defect, but don't know how to change this. Sorry.

Original comment by robert.w...@web.de on 29 Nov 2011 at 1:43

GoogleCodeExporter commented 8 years ago 
Hi Rob, 

Thanks for picking this up. I forgot to fix that up and will do so in the next 
build (probably tonight). I will probably add a HasWritableNode interface 
(which extends HasNode) for this, so that HasNode is only for retrieving the 
Node in cases where you don't want the Node injected by the loader.

Original comment by zonski on 29 Nov 2011 at 11:16

GoogleCodeExporter commented 8 years ago 
This has been fixed in the latest release 'alpha-b3', available from the 
downloads page.

Original comment by zonski on 30 Nov 2011 at 10:37