rocketscream / TinyReflowController

An all-in-one Arduino compatible reflow controller powered by ATtiny1634R
121 stars 64 forks source link

[Suggestion] #3

Open gitfve opened 4 years ago

gitfve commented 4 years ago

-Hints-

rocketscream commented 4 years ago

In the setup, set filter to MAX31856_NOISE_FILTER_50HZ or ..._60HZ you newer use the filter?

This is good suggestion. I'll check whether the Adafruit MAX31856 library has this enabled. If not, I will do a pull first.

Updating display every 100ms, why? It is real time heavy... It was initially set at a lower rate during development stage. But, as it is a human interface, whenever a human presses a button or an error occurs, user expect instant visual feedback on the display. Refreshing it slower will let the user think the button presses are not working and other visual feedback issue.

Reading sensor every 1000ms? Must be more often for to get PID more accurate

Yes, we do not need to sample that fast. In previous version it was even sampled once per second. But, for simplicity with the UI refresh rate, it was set same as the display refresh rate. It doesn't do any harm sampling any faster too.

Code clean up, and use some function and not so many Global vars:-(

Please suggest which variable that can be further improved into a local variable. And do a pull request.

Option to select more profiles 1..10 Option to select the 50/60HZ filter. Option to set some PID values.

Not sure whether any more profiles is of any use as most user just want to reflow either a leaded or lead free. The filter option is good and as explained above. Tweaking the PID values is great but it will open up a whole bigger cans of issues later (user might tweak it wrongly, oven not responding as expected, profile goes off, etc). You can always use the default values and tweak it from there.

One of the objective of the controller is to be simple and does what it needs to do: reflow.

Teknost commented 4 years ago

Additional profiles for 3D printer filament drying would be awesome. i.e. straight baking for a few hours at 40C or 80C.