search

rocketseat-education / ignite-template-componentizando-a-aplicacao

MIT License
37 stars 151 forks source link

How to fix sidebar height? #3

Closed franklaercio closed 3 years ago

franklaercio commented 3 years ago

What code on is ignite-template-componentizando-a-aplicacao affected? (https://github.com/rocketseat-education/ignite-template-componentizando-a-aplicacao/blob/main/src/styles/sidebar.scss)

What part(s) of the code would you like to see updated?

At this moment the sidebar stay this way: image with error content

I tried to define the height with 100vh, but case you scroll the page stays like this: image with error content

yuriBaza23 commented 3 years ago

Hi @franklaercio ,

I solved this problem by adding by doing: In src/styles/sidebar.scss Add in nav.sidebar

min-height: 100vh;

Sorry for my English.

fariasmateuss commented 3 years ago

Hi!👋 Complementing what Yuri's comment.

You can use CSS overflow hidden: any content that extends beyond the box is completely hidden; or relative unit VH: Relative to the viewport’s height.

franklaercio commented 3 years ago

All of you guys, I really thank you.