search

rockettheme / toolbox

RocketTheme\Toolbox package contains a set of reusable PHP interfaces, classes and traits.
MIT License
21 stars 16 forks source link

Improve session start check #13

Closed npotier closed 7 years ago

npotier commented 8 years ago

Hi @mahagr this is a new nice PR. I've taken care of your previous comments, thanks.

mahagr commented 8 years ago

Hmm, we only support PHP 5.4+, so maybe there's no point of having fallback to the older code?

npotier commented 8 years ago

Ok, is this better ? Thanks.

mahagr commented 8 years ago

Yup, much better. I'll give @flaviocopes and @rhukster time to test this out before merging it.

flaviocopes commented 8 years ago

What problem does this solve?

mahagr commented 8 years ago

From what I can see, it doesn't initialize session if you're in CLI.