search

rockhymas / iberia

Minecraft Made Harder
Other
9 stars 5 forks source link

1.12.2 update #31

Closed cleverpanda closed 6 years ago

cleverpanda commented 6 years ago

bunch of tiny things Itemstack nullability. I checked all instances and there was only one that could possibly actually be null. simplified armor gui interactions

cleverpanda commented 6 years ago

@rockhymas

cleverpanda commented 6 years ago

All good now then? :)

rockhymas commented 6 years ago

Testing this out a bit, I ran into the following exception when loading the mod: 

[11:37:56] [main/ERROR]: A critical error occurred instantiating the gui factory for mod iberia
java.lang.InstantiationException: null
    at sun.reflect.InstantiationExceptionConstructorAccessorImpl.newInstance(InstantiationExceptionConstructorAccessorImpl.java:48) ~[?:1.8.0_151]
    at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[?:1.8.0_151]
    at java.lang.Class.newInstance(Class.java:442) ~[?:1.8.0_151]
    at net.minecraftforge.fml.client.FMLClientHandler.finishMinecraftLoading(FMLClientHandler.java:394) [FMLClientHandler.class:?]
    at net.minecraft.client.Minecraft.init(Minecraft.java:534) [Minecraft.class:?]
    at net.minecraft.client.Minecraft.run(Minecraft.java:377) [Minecraft.class:?]
    at net.minecraft.client.main.Main.main(SourceFile:123) [Main.class:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_151]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_151]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_151]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_151]
    at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
    at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_151]
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_151]
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_151]
    at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_151]
    at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
    at GradleStart.main(GradleStart.java:26) [start/:?]
rockhymas commented 6 years ago

I bet the error means that the in game mod configuration gui won't work

rockhymas commented 6 years ago

Hey @cleverpanda thanks again. This helped so much. I squashed the commits down, did a bit more cleanup and testing, and just uploaded a release to curseforge. Have fun playing with it, and let me know if you run into any bugs.