search

rocklabs-io / ic-py

Python Agent Library for the DFINITY Internet Computer
MIT License
128 stars 27 forks source link

IC certificate verification missing #76

Open domwoe opened 2 years ago

domwoe commented 2 years ago

I noticed you're missing the certificate verification and found the draft PR #56. What's the blocker here?

Myse1f commented 2 years ago

The verification in each request would degrade the performance.

Besides, the wasmer package requires python3.7 or above.

domwoe commented 2 years ago

I worry that users may get a false sense of security using your agent.

You could add verification as an opt out feature. Note also, that it's only used for the read_state API when you actually get a result.

Besides using WASM you could also look for a BLS implementation in Python or a BLS implementation in Rust that could be called from Python using FFI.

Myse1f commented 2 years ago

Actually, we try to find other BLS implementations in Python, but all seem incompatible with the IC one.