rocklabs-io / ic-py

Python Agent Library for the DFINITY Internet Computer
MIT License
128 stars 27 forks source link

Infinite timeouts make the library hard to use in production #98

Closed Dfinity-skaestle closed 1 year ago

Dfinity-skaestle commented 1 year ago

The timeouts I have been setting are somewhat arbitrary and should really be configurable, but I think this is far better than no timeouts.

We use this library for benchmarking, and if requests get stuck "forever" many of those benchmarks never complete and stop making progress.

Ultimately, the user should retry if things time out, which is difficult if requests don't time out in this library.