search

rockowitz / ddcui

Graphical user interface for ddcutil - control monitor settings
http://www.ddcutil.com
GNU General Public License v2.0
147 stars 2 forks source link

Truncated value #11

Open 532910 opened 4 years ago

532910 commented 4 years ago

image

rockowitz commented 4 years ago

On further consideration, this appears to be another case of theme variability, since there's enough room for 3 digit numbers on my screen.  So it would seem that entry field size needs to increased to accommodate this variability.

On 9/27/19 3:26 AM, sergio wrote:

image https://user-images.githubusercontent.com/14617699/65750481-30be9200-e111-11e9-920e-429980a7a15a.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3TPSHWODYWPSJVCFQ3QLWYSJA5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HOCOPZA, or mute the thread https://github.com/notifications/unsubscribe-auth/ADMGY3X7UCRJGUAMBQO6O63QLWYSJANCNFSM4I3C2DVQ.

532910 commented 4 years ago

image

Even with default Fusion theme:

rockowitz commented 4 years ago

Truncated semicolon? I think you're referring to the colon at the end of "Max:", but all look correct in your screenshot.

All the slider look correct in your screenshot.

Branch 0.0.7 increases the width of the spinbox and max value field to allow for 5 digit numbers and horizontal spinbox buttons.

532910 commented 4 years ago

Sorry for the late answer, I've misses it.

I don't know why "Max:" looks fine though I referred to the colon at the end of it.

can't compile 0.0.7:

src/nongui/feature_value.cpp: In member function ‘DDCA_MCCS_Version_Spec FeatureValue::vspec() const’:
src/nongui/feature_value.cpp:72:19: error: ‘struct DDCA_Feature_Metadata’ has no member named ‘vcp_version’
   72 |    return _finfo->vcp_version;
      |                   ^~~~~~~~~~~
src/nongui/feature_value.cpp: In member function ‘void FeatureValue::dbgrpt() const’:
src/nongui/feature_value.cpp:128:5: error: ‘ddca_dbgrpt_feature_metadata’ was not declared in this scope; did you mean ‘ddca_free_feature_metadata’?
  128 |     ddca_dbgrpt_feature_metadata(_finfo, 1);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |     ddca_free_feature_metadata
make: *** [Makefile:998: feature_value.o] Error 1

ddcutil 0.9.7 master

rockowitz commented 4 years ago

Sergio,

It looks like you're trying to use outdated libddcutil header files.   One possible reason is that the ddcutil.pc pkgconfig file is not found.  Things can get confusing when using "make install" to install ddcutil under /usr/local.  Attached is a section  from the documentation for upcoming release 0.0.8.

Another source of obscure errors is outdated entries is file CMakeCache.txt.  I erase it every time I run cmake.

Hope this helps.

Sanford

You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3RXZSLEPGWGFSEMKHDQUR7BNA5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEQHWGY#issuecomment-555776795, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGY3SVASTREG2QLRTXZQ3QUR7BNANCNFSM4I3C2DVQ.

532910 commented 4 years ago

Aaa, 0.0.7 requires ddcutil 0.9.8 and doesn't work with master.

532910 commented 4 years ago

I've compiled 0.0.7 and 0.0.8.

Branch 0.0.7 increases the width of the spinbox and max value field to allow for 5 digit numbers and horizontal spinbox buttons.

It's true. But only for 0.0.7

0.0.8 looks bad: image

rockowitz commented 4 years ago

More generally, the current development branch of ddcui requires the current development branch of ddcutil.

On 11/21/19 10:31 PM, sergio wrote:

Aaa, 0.0.7 requires ddcutil 0.9.8 and doesn't work with master.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3XM2FWN25JFU5YQLUTQU5HBXA5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE4NNOY#issuecomment-557373115, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGY3UOAA2COZ5QRPLAHT3QU5HBXANCNFSM4I3C2DVQ.

532910 commented 4 years ago

0.0.7 and 0.0.8 are releases and master is a development branch. I don't ask you to do so, but this is the first assumption that arises when I see it.

rockowitz commented 4 years ago

Sergio,

Thanks for reporting this.  The layout is a work in progress.

Note that development branch 0.0.8 is just a continuation of branch 0.0.7.  Launchpad constraints necessitated the version/branch number bump.   I'll delete branch 0.0.7.

A lot of work has gone into ddcui 0.0.8 since I last uploaded to github, and there have been some related changes to ddcutil 0.9.8 as well.  I expect to do a major upload this weekend, and suggest you wait until then.

Regards, Sanford

On 11/21/19 10:39 PM, sergio wrote:

I've compiled 0.0.7 and 0.0.8.

Branch 0.0.7 increases the width of the spinbox and max value
field to allow for 5 digit numbers and horizontal spinbox buttons.

It's true. But only for 0.0.7

0.0.8 looks bad: image https://user-images.githubusercontent.com/14617699/69396268-c5e59d80-0cf2-11ea-812e-4cb452c3220e.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3VIY5BHR5QK4RFGKRTQU5H5ZA5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE4NZLQ#issuecomment-557374638, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGY3SZMLVZ6BLBLWNOXN3QU5H5ZANCNFSM4I3C2DVQ.

rockowitz commented 4 years ago

I appreciate how using future release numbers to name a development branch might cause confusion,  but workflows I looked at regard master as the official source and everything else as some sort of development branch.  Releases for ddcutil/ddcui are tagged points along the master branch, and published as releases in github.

Sanford

On 11/22/19 10:08 AM, sergio wrote:

|0.0.7| and |0.0.8| are releases and |master| is a development branch. I don't ask you to do so, but this is the first assumption that arises when I see it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3UIRK2D7FOCQ2OKRYLQU7YYNA5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE544OY#issuecomment-557567547, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGY3Q56LYBV5RC2RDW6ELQU7YYNANCNFSM4I3C2DVQ.

rockowitz commented 4 years ago

ddcui branch 0.0.8 has been renamed to 0.0.8-dev to make its purpose clearer.  Similarly, ddcutil branch 0.9.8 has been renamed to 0.9.8-dev.

Sanford

On 11/22/19 10:08 AM, sergio wrote:

|0.0.7| and |0.0.8| are releases and |master| is a development branch. I don't ask you to do so, but this is the first assumption that arises when I see it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3UIRK2D7FOCQ2OKRYLQU7YYNA5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE544OY#issuecomment-557567547, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGY3Q56LYBV5RC2RDW6ELQU7YYNANCNFSM4I3C2DVQ.

532910 commented 4 years ago

v0.1.0 Adwaita-Dark still looks bad: image

532910 commented 4 years ago

Fusion looks better, except sliders: image

rockowitz commented 4 years ago

Thought I'd made the numeric field huge, but apparently on Adwaita-Dark, with the horizontal spin buttons, it's still not enough.  I'll take a look.  Thanks.

On 12/7/19 4:11 AM, sergio wrote:

v0.1.0 still looks bad: image https://user-images.githubusercontent.com/14617699/70371974-a0f44b80-18ea-11ea-9e5c-041c2a89d38b.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3UTCXL7HWXQRENCIUTQXNSERA5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGCDYY#issuecomment-562831843, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGY3TGLQTPCWRKSLXIBHLQXNSERANCNFSM4I3C2DVQ.

rockowitz commented 4 years ago

Is the issue that the sliders are scrunched at the top of the field, or something else?  I just took that as the nature of Fusion.  Will look at reducing the slider height to better fit the value field.

On 12/7/19 4:15 AM, sergio wrote:

Fusion looks better, except sliders: image https://user-images.githubusercontent.com/14617699/70372030-3263bd80-18eb-11ea-917a-8667a1be8d84.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3WKZU6PCACVWMTNTRLQXNST3A5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGCGPY#issuecomment-562832191, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGY3WP7OMINAYOHXSVJQLQXNST3ANCNFSM4I3C2DVQ.

rockowitz commented 4 years ago

Development branch 0.1.1-dev increases the size of the spin box value field yet again. Let me know if it works for you.

On 12/07/2019 04:11 AM, sergio wrote:

v0.1.0 still looks bad: image https://user-images.githubusercontent.com/14617699/70371974-a0f44b80-18ea-11ea-9e5c-041c2a89d38b.png

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcui/issues/11?email_source=notifications&email_token=ADMGY3UTCXL7HWXQRENCIUTQXNSERA5CNFSM4I3C2DV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGGCDYY#issuecomment-562831843, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADMGY3TGLQTPCWRKSLXIBHLQXNSERANCNFSM4I3C2DVQ.