rockowitz / ddcui

Graphical user interface for ddcutil - control monitor settings
http://www.ddcutil.com
GNU General Public License v2.0
147 stars 2 forks source link

Questions regarding "Require control key to move sliders" #38

Closed stdedos closed 1 year ago

stdedos commented 2 years ago

Hello there. I tried to use the "Require control key to move sliders" feature, as I tend to find it "disruptive" when the scrolling wheel changes stuff, when all I meant to do is scroll the view.

I am using Ubuntu, and I have found the followings issues:

  1. The sliders are not moved by scrolling, regardless of the option
  2. The text/number fields, and the dropdown boxes are moved using scrolling and they ignore the "Ctrl" setting. I would like that those would also respect that option, since it's quite possible that the mouse hovering over them can happen, and leads to sad effects. (Specifically, I managed to queue so many operations in ddcui, I was unable to set the things I wanted to set, and I had to kill and restart it to fix the issue)

It might be good to have a UI indication that pressing Ctrl is necessary, to avoid "forgetting" about that stuff.

Thank you for such a functional program otherwise :-D

rockowitz commented 2 years ago

If the value sliders never work, that is a bug. The window sliders should always work, regardless of the Require Control Key setting. This will be hard to debug remotely. What releases of Ubuntu, Qt, and ddcui are you using?

I agree that the Require Control Key setting should apply to all value fields that can be changed by the mouse wheel and will make that change.

Is the UI indication really necessary? By default, the control key is not required because that would be too confusing to new users. So all but power users will have to select the option from the User Interface options menu each time they use ddcui . (Power users can use the --require-control-key command line option or specify it in the ddcutilrc configuration file, but they would think they would realize that the option is set if changing values does not work.)

Thanks for your input. I'm glad you find ddcui useful. It's an early release, so I expect there will be many more issues to address.

stdedos commented 2 years ago

If the value sliders never work, that is a bug. The window sliders should always work, regardless of the Require Control Key setting. This will be hard to debug remotely. What releases of Ubuntu, Qt, and ddcui are you using?

Ubuntu 20.04.4, QT 5.12.8, ddcui 0.1.2/0.9.9 (PS: pls pls create a dialog that auto-creates the "basic debugging stuff" you want for basic troubleshooting. It's plain PITN to have to "source" them separately)

Is the UI indication really necessary?

It's not really necessary, but if you have the space to show it (e.g. status bar), a 30x20 px indicator ala e.g. any text editor's INS/OVR indicator "cannot hurt either". Ofc this is more of a niche request for me to not have to navigate to an "esoteric" settings dialog to verify what is the configuration status (I kinda hate "distributed" settings for a program - it's my strong belief that programs SHOULD have single point of truth for settings, even if they choose to show them piece-wise in other places too).

but they would think they would realize that the option is set if changing values does not work

that is true also ofc

rockowitz commented 2 years ago

Making the "require control key" option apply to spin boxes and combo boxes is proving non-trivial to implement. However, I agree it should be done.

ddcutil 0.9.9 and ddcui 0.1.2 are quite ancient. Currently, ddcutil 1.2.2 is in Debian Bookworm (testing) and will be packaged in Ubuntu 21.04. ddcui 0.2.1 is in Debian acceptance testing and should appear in Sid and Bookworm in a few weeks.

Note that all maintenance happens on the ddcutil and ddcui development branches, currently 1.2.3-dev and 0.2.2-dev.

Command ddcutil environment --verbose gathers extensive information for the remote diagnosis of problems in the command line program and shared library. Unfortunately, remotely diagnosing a GUI program is much harder and relies on user reports. If the information that can be gathered for ddcui increases I'll consider a dialog box and/or command option to gather debugging information, but for now I think Help->About ddcui and Help->About Qt are adequate.

stdedos commented 2 years ago

If the information that can be gathered for ddcui increases I'll consider a dialog box and/or command option to gather debugging information, but for now I think Help->About ddcui and Help->About Qt are adequate.

Just saying, a command in the GUI that copies

- Ubuntu 20.04.4
- QT 5.12.8
- ddcui 0.1.2/0.9.9

It's a much faster and convenient way for both sides to get the data necessary

rockowitz commented 2 years ago

Branch 0.2.2-dev has been updated to disallow any feature value changes when the User Interface Option "Require control key to change values" is set. When in the Features view, if feature changes are disallowed the feature values are shown as disabled, and message "CTRL key required to change feature values" is shown in the status bar. The colour of disabled feature widgets may have to be tweaked for legibility depending on style. Thank you @stdedos for the suggestion.

rockowitz commented 1 year ago

The control key changes are in the new ddcui release, 0.3.0. Thank you again @stdedos for the suggestion.