search

rockowitz / ddcutil

Control monitor settings using DDC/CI and USB
http://www.ddcutil.com
GNU General Public License v2.0
978 stars 40 forks source link

pkg-config script issue #38

Closed FedeDP closed 6 years ago

FedeDP commented 6 years ago

Hi, first of all let me thank you for your great work! By the way, trying to build an example with gcc, i realized that pkg-config --libs --cflags ddcutil does not set required "-lddcutil" (that seems only needed flag too). On my system (archlinux) version 0.8.4 sets: -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -lglib-2.0 -lXrandr -lX11

But without "-lddcutil" i am not able to build. I guess that adding: Libs: -L${libdir} -lddcutil to ddcutil.pc.in should do the trick (if i am correct). At least, that is what x11.pc does ("Libs: -L${libdir} -lX11").

rockowitz commented 6 years ago

Thank you for reporting the bug. The Libs: line has been modified as per your suggestion and the change will appear in the upcoming point release.

If you're writing to the C API please keep me updated on how you're doing. The API is a work in progress. I'd appreciate hearing what works well, what is needlessly difficult, and is obscure.

Regards, Sanford

On 11/14/2017 01:32 PM, Federico wrote:

Hi, first of all let me thank you for your great work! By the way, trying to build an example with gcc, i realized that |pkg-config --libs --cflags ddcutil| does not set required "-lddcutil" (that seems only needed flag too). On my system (archlinux) version 0.8.4 sets: |-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -lglib-2.0 -lXrandr -lX11|

But without "-lddcutil" i am not able to build. I guess that adding: |Libs: -L${libdir} -lddcutil| to ddcutil.pc.in should do the trick (if i am correct). At least, that is what x11.pc does ("Libs: -L${libdir} -lX11").

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcutil/issues/38, or mute the thread https://github.com/notifications/unsubscribe-auth/ANhsbofeLjpGLd0PA7EhclEakBruIU0Zks5s2dyygaJpZM4QdywN.

FedeDP commented 6 years ago

I'm only using ddca_set_continuous_vcp_value (and main loop as per https://github.com/rockowitz/ddcutil/blob/master/src/sample_clients/clmain.c) for my project (https://github.com/FedeDP/Clightd/tree/ddcutil#ddcutil-support), so no issues for the api.

Again, thanks for this software!

EDIT: thanks for the mention in the 0.8.5 release notes!:)