Closed dracwyrm closed 6 years ago
Jonathan,
Thanks for the clear reports.
Simplest solution: Delete or comment out the line "AM_CFLAGS += -Wpedantic" in file src/ddc/Makefile.am, rerun automake and configure and then build.
Background: I had added the -Wpedantic flag trying to identify the source of a benign (to ddcutil) error report in Coverity scan regarding __Float128 being undefined. The flag causes warnings to be issued for violations of strict ISO compatibility. If -Werror is also set, this results in a fatal error. In particular, variadic macros, PROGRAM_LOGIC_ERROR() in this case, without variadic arguments are disallowed. The use of PROGRAM_LOGIC_ERROR() in this way was only encountered if "--disable-usb" was passed to configure.
The overzealous use of -Wpedantic will be fixed in the next point release.
Sanford
On 01/27/2018 09:34 AM, Jonathan Scruggs wrote:
On Gentoo, a number of users are reporting this error. Since build logs are very long, I'll post the links to them.
One log is here: https://645830.bugs.gentoo.org/attachment.cgi?id=516796 Another user has slightly different functions that exhibit this: https://bugs.gentoo.org/645782
Is there a dependency version or lack there of that needs consideration?
Thanks.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcutil/issues/45, or mute the thread https://github.com/notifications/unsubscribe-auth/ANhsbghw75Gyn86BQEhneKnOL7SSIq2vks5tOzPcgaJpZM4RvT-i.
Thanks for the feedback. Do you know when the next point release will be?
Unless there are urgent issues, the next actual point release is several weeks away.
Sanford
On 01/28/2018 03:49 AM, Jonathan Scruggs wrote:
Thanks for the feedback. Do you know when the next point release will be?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rockowitz/ddcutil/issues/45#issuecomment-361047478, or mute the thread https://github.com/notifications/unsubscribe-auth/ANhsblabUSTUPR9yArVrLGjVwGbDPWvzks5tPDSwgaJpZM4RvT-i.
The -Wpedantic compile option requiring strict C99 compliance is no longer used in Release 0.9.0, so this problem should be eliminated.
On Gentoo, a number of users are reporting this error. Since build logs are very long, I'll post the links to them.
One log is here: https://645830.bugs.gentoo.org/attachment.cgi?id=516796 Another user has slightly different functions that exhibit this: https://bugs.gentoo.org/645782
Is there a dependency version or lack there of that needs consideration?
Thanks.