rockrider69 / service.LanguagePreferenceManager

A manager for audio and subtitle preferences
GNU General Public License v2.0
17 stars 1 forks source link

Fix Language Code Conflict #10

Closed BrutuZ closed 6 months ago

BrutuZ commented 6 months ago

Changes tested on 2-3 episodes, intended language selected and no more crashes ( Fixes #9 )

I refrained from formatting the code to keep the diff small and easy to read. Didn't work out all that well for the whole PR given the desync between master and the latest branch (V1.0.3) but at least 861dc783d53668bfdfaf97e2f730166cca541548 ended up small πŸ˜„. If allowed I could add another commit to address it as there are a few stray spaces and the likes

rockrider69 commented 6 months ago

Thx, and if you have more proposals for code fix and/or improvement, feel free !

BrutuZ commented 6 months ago

I kind of overlooked bumping the version number inside addon.xml or adding to the changelog πŸ˜…

rockrider69 commented 6 months ago

No problem I saw that, I'll do it. I might include something more before closing the version and pushing to KODI rep. (If time allows before few weeks off comingπŸ˜„)