Rework signs & songs option

ghost commented 11 months ago

Currently there is an option to ignore signs and songs subtitles when choosing the sub track. I think it would be good to rework this so that signs and songs can be prioritised as well, for dub watchers. Perhaps making signs and songs ignored by default, but adding a custom options suffix like "-ss" to use the signs subs could achieve this. So, for example, if I wanted to watch in English by default but fall back to full subs when there is no dub, I could put the following in custom options.

eng:eng-ss>eng:non>any:eng

rockrider69 commented 11 months ago

@Xyl-AU Thanks for the interest and suggestion, I'll have to think about that !

Just to be sure: Eng/Signs&Songs tracks we'd target here contain strictly that (signs and songs translations) and no dialog at all, full, nor forced ?

I am asking because I have seen full subs, or sometimes forced ones, which are including Signs&Songs also. But this might be wrong practices...

Also please note that with this rule (eng:eng-ss>eng:non>any:eng) we would indeed prioritize Signs&Songs, over english Forced dialog if ever they both exists separately. No way to get them both in that situation unless a merged Signs/Songs/Forced ;)

ghost commented 11 months ago

@Xyl-AU Thanks for the interest and suggestion, I'll have to think about that !

Just to be sure: Eng/Signs&Songs tracks we'd target here contain strictly that (signs and songs translations) and no dialog at all, full, nor forced ?

I am asking because I have seen full subs, or sometimes forced ones, which are including Signs&Songs also. But this might be wrong practices...

Also please note that with this rule (eng:eng-ss>eng:non>any:eng) we would indeed prioritize Signs&Songs, over english Forced dialog if ever they both exists separately. No way to get them both in that situation unless a merged Signs/Songs/Forced ;)

Yes, when there is a signs and songs track it includes just that. There are rare exceptions like when a character is speaking a language that is not the primary audio language. For example, Mushoku Tensei has its own made up language that is spoken sometimes. Japanese subtitles are embedded into the video, and English subtitles would be available in both the signs/songs and full subtitle tracks as it treats the embedded subtitles as a sign.

Full subtitle tracks also usually include the signs and songs, but with the dialogue as well obviously, which is unneeded when watching in a dub.

Usually if there is a track marked as forced it is the signs and songs track, but of course since this is not a standard it's not super consistent with the tagging of default/forced/etc., however you will almost never see forced on other tracks when there is a signs and songs.

rockrider69 commented 11 months ago

@Xyl-AU I have been thinking addressing your proposal, a -ss tag to prioritize Signs&Songs subs, and would like to check a couple of things with you :

I will rather keep the general "Toggle Ignore Signs and Songs" as it is (default false) as well as the alternative possibility to exclude these tracks via the generic "Blacklist keywords list".
the -ss tag would only be useable in the "custom sub preferences" (exactly as in your example). No new dedicated field/tag in the "normal" sub preferences.
if present the -ss tag will be tested BEFORE the Toggle Ignore Signs and Songs", or the "Blacklist Keywords" filters, hence take precedence above these. This allows to only overide the current and general ignore rule for specific languages while continue to ignore S&S for all others.

Not sure yet if I miss something key for the logic, but what do you think of the principles ?

rockrider69 commented 10 months ago

@Xyl-AU If you have time please try 1.0.3BETA1 release (just published) and tell me ...

ghost commented 10 months ago

@Xyl-AU If you have time please try 1.0.3BETA1 release (just published) and tell me ...

I've had time to play around with it and it seems like it works how I was envisioning it, thanks a lot!

rockrider69 commented 10 months ago

Great! I plan to include the feature in the 1.0.3 version. Still working on a couple of other things though. In the mean time you can continue to use this beta1 version if it suits you,.. And let me know if you spot any problem of course. Thank you for proposing this. I find it interesting and I tried to make as generic as possible, so that other tags could even be introduced for such fine prioritization.

(I'll mark the issue closed when delivering the 1.0.3 version)

rockrider69 commented 9 months ago

Hi ! 1.0.3 is now final and will soon be pushed to Kodi Repository. Closing this issue.

rockrider69 / service.LanguagePreferenceManager

Rework signs & songs option #7