search

rocksdanister / lively

Free and open-source software that allows users to set animated desktop wallpapers and screensavers powered by WinUI 3.
https://rocksdanister.com/lively
GNU General Public License v3.0
14.75k stars 1.05k forks source link

fix lively on Windows 11 26002 and later #2050

Closed everything411 closed 8 months ago

everything411 commented 8 months ago

The WorkerW window we created is a child window of Progman window on Windows 11 Insider Canary build 26002 and later. This pull request resolves #2030 #2047

Spy++ output

0x000100EC "Program Manager" Progman
  0x000100EE "" SHELLDLL_DefView
    0x000100F0 "FolderView" SysListView32
  0x00100B8A "" WorkerW       <-- This is the WorkerW instance we are after!
CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

everything411 commented 8 months ago

I'm not sure if 26002 is the minimum affected version because I'm already on 26016. The earliest bug report here is #2030 and it says 26002 is affected.

everything411 commented 8 months ago

@Surferdbeere @LammariOm please test this build. https://mega.nz/file/dyUQiLjQ#TJykB0eWuVHVLdfwz7X_dniLDFszVN6TTuXhzI4FBgI

rocksdanister commented 8 months ago

Good investigative work!

From what I understand Microsoft is trying to change the desktop implementation in the recent insider builds. The changes may end up being different or never reach the final stable build, so checking version may not be a good idea: Environment.OSVersion.Version.Build >= 26002

What if the first search fails we check for progman child Window as a fallback or something like that?

I don't have insider build with me at the moment, things to verify with this fix:

  1. Does wallpaper input (mouse/keyboard) still work.
  2. Does opening chatgpt, taskview and app switcher crash the wallpaper.
  3. Does the wallpaper pause algorithms still work properly.
  4. Does the wallpaper restore properly when explorer/workerw crash.
everything411 commented 8 months ago
  1. Does wallpaper input (mouse/keyboard) still work. mouse and keyboard work properly
  2. Does opening chatgpt, taskview and app switcher crash the wallpaper. taskview and app switcher do not crash the wallpaper. copilot is not available in my country so I cannot verify if it really works. but at least the copilot sidebar saying it is not available can show properly and the wallpaper does not crash.
  3. Does the wallpaper pause algorithms still work properly. I haven't checked every combination of these settings, but I think it can work properly.
  4. Does the wallpaper restore properly when explorer/workerw crash. the wallpaper restore properly after I kill explorer.exe and relaunch it
rocksdanister commented 7 months ago

Looks like things changed again https://github.com/rocksdanister/lively/issues/2074

shangsh commented 7 months ago

Looks like things changed again #2074 So what's the solution?

keshka commented 5 months ago

The issue persists on build 26080.ge_release.240308-1400