search

rocksdanister / lively

Free and open-source software that allows users to set animated desktop wallpapers and screensavers powered by WinUI 3.
https://rocksdanister.com/lively
GNU General Public License v3.0
14.75k stars 1.05k forks source link

Explorer crash detecting when exiting RetroBar #2061

Closed teknixstuff closed 8 months ago

teknixstuff commented 8 months ago

Describe the bug When enabling or disabling retrobar, lively believes explorer has restarted

To Reproduce Steps to reproduce the behavior:

  1. Install Lively Wallpaper
  2. Run RetroBar
  3. Within 30 seconds, right-click the taskbar and select exit retrobar
  4. Lively pops up the "Windows Explorer has restarted twice in 30 seconds" dialog
  5. Note that, if you look in task manager (or any other process monitoring software), explorer still has the same PID etc that it did at the start.

Expected behavior Lively should detect that explorer hasn't restarted and not show the dialog

Screenshots/Video I do not believe these would be helpful

Desktop (please complete the following information):

Additional context No additional context available

Log file (Important)

2024-01-07 08:16:43.9306|INFO|Lively.App|
Lively v2.0.7.4 x64 desktop-native en-GB
OS: Microsoft Windows 10 IoT Enterprise LTSC 10.0.19044
CPU: Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz
GPU: Intel(R) UHD Graphics 620
GPU: NVIDIA GeForce MX150

2024-01-07 08:16:44.9540|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:16:45.0297|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:16:45.0297|INFO|Lively.Core.WinDesktopCore|Hooking WorkerW events..
2024-01-07 08:16:46.1716|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:16:46.1716|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
2024-01-07 08:17:34.6872|INFO|Lively.App|AppUpdate status: uptodate
2024-01-07 08:19:20.1699|INFO|Lively.Core.Suspend.Playback|Lockscreen Session started!
2024-01-07 08:19:24.6637|INFO|Lively.Core.Suspend.Playback|Lockscreen Session ended!
2024-01-07 08:22:08.5430|INFO|Lively.Core.Suspend.Playback|Lockscreen Session started!
2024-01-07 08:22:14.6398|INFO|Lively.Core.Suspend.Playback|Lockscreen Session ended!
2024-01-07 08:22:14.8034|INFO|Lively.Core.WinDesktopCore|Display settings changed, screen(s):
2024-01-07 08:22:14.8034|INFO|Lively.Core.WinDesktopCore|\\.\DISPLAY1 {X=0,Y=0,Width=1920,Height=1080}
2024-01-07 08:22:26.3245|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|WM_TASKBARCREATED: New taskbar created.
2024-01-07 08:22:26.3245|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer crashed, pid mismatch: 8680 != 11080
2024-01-07 08:22:26.3245|INFO|Lively.Core.WinDesktopCore|Restarting wallpaper service..
2024-01-07 08:22:26.3245|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:22:26.3245|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:22:26.3390|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:22:26.3390|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
2024-01-07 08:22:45.8943|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|WM_TASKBARCREATED: New taskbar created.
2024-01-07 08:22:45.8943|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer crashed, pid mismatch: 11080 != 1460
2024-01-07 08:22:45.8943|WARN|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer restarted multiple times in the last 30s.
2024-01-07 08:22:45.8943|INFO|Lively.Core.WinDesktopCore|Restarting wallpaper service..
2024-01-07 08:22:45.8943|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:22:45.9081|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:22:45.9081|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:22:45.9081|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
2024-01-07 08:22:54.0515|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|WM_TASKBARCREATED: New taskbar created.
2024-01-07 08:22:54.0515|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer crashed, pid mismatch: 1460 != 1072
2024-01-07 08:22:54.0515|WARN|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer restarted multiple times in the last 30s.
2024-01-07 08:22:54.0515|INFO|Lively.Core.WinDesktopCore|Restarting wallpaper service..
2024-01-07 08:22:54.0515|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:22:54.0914|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:22:54.0914|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:22:54.0914|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
2024-01-07 08:23:15.8207|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|WM_TASKBARCREATED: New taskbar created.
2024-01-07 08:23:15.8207|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer crashed, pid mismatch: 1072 != 8524
2024-01-07 08:23:15.8207|WARN|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer restarted multiple times in the last 30s.
2024-01-07 08:23:15.8207|INFO|Lively.Core.WinDesktopCore|Restarting wallpaper service..
2024-01-07 08:23:15.8207|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:23:15.8871|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:23:15.8871|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:23:15.8871|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
2024-01-07 08:23:35.3182|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|WM_TASKBARCREATED: New taskbar created.
2024-01-07 08:23:35.3182|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer crashed, pid mismatch: 8524 != 1644
2024-01-07 08:23:35.3182|WARN|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer restarted multiple times in the last 30s.
2024-01-07 08:23:35.3182|INFO|Lively.Core.WinDesktopCore|Restarting wallpaper service..
2024-01-07 08:23:35.3182|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:23:35.3660|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:23:35.3706|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:23:35.3706|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
2024-01-07 08:23:54.2823|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|WM_TASKBARCREATED: New taskbar created.
2024-01-07 08:23:54.2823|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer crashed, pid mismatch: 1644 != 8280
2024-01-07 08:23:54.2823|WARN|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer restarted multiple times in the last 30s.
2024-01-07 08:23:54.2823|INFO|Lively.Core.WinDesktopCore|Restarting wallpaper service..
2024-01-07 08:23:54.2823|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:23:54.3332|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:23:54.3332|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:23:54.3389|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
2024-01-07 08:26:33.3912|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|WM_TASKBARCREATED: New taskbar created.
2024-01-07 08:26:33.3912|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer crashed, pid mismatch: 8280 != 1472
2024-01-07 08:26:33.3912|INFO|Lively.Core.WinDesktopCore|Restarting wallpaper service..
2024-01-07 08:26:33.3912|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:26:33.4791|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:26:33.4791|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:26:33.4791|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
2024-01-07 08:26:39.6205|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|WM_TASKBARCREATED: New taskbar created.
2024-01-07 08:26:39.6205|INFO|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer crashed, pid mismatch: 1472 != 8680
2024-01-07 08:26:39.6205|WARN|Lively.Views.WindowMsg.WndProcMsgWindow|Explorer restarted multiple times in the last 30s.
2024-01-07 08:26:39.6205|INFO|Lively.Core.WinDesktopCore|Restarting wallpaper service..
2024-01-07 08:26:39.6205|INFO|Lively.Core.WinDesktopCore|WorkerW initializing..
2024-01-07 08:26:39.6889|INFO|Lively.Core.WinDesktopCore|WorkerW initialized 67664
2024-01-07 08:26:39.6889|INFO|Lively.Views.WindowMsg.RawInputMsgWindow|Desktop handles updated.
2024-01-07 08:26:39.6889|INFO|Lively.Core.Suspend.Playback|Desktop handles updated.
rocksdanister commented 8 months ago

This is not false, Lively is checking specifically taskbar process pid: https://github.com/rocksdanister/lively/blob/9142f6a4cfc222cd494f205a5daaa1a0238282e3/src/Lively/Lively/Views/WindowMsg/WndProcMsgWindow.xaml.cs#L97-L101

teknixstuff commented 8 months ago

Yes, but couldn't an option be added either to check via a different method, or to change/disable the crash dialog?

rocksdanister commented 8 months ago

I don't see this as a big problem, only happens if you open and close Retrobar in 30s window.

Lively needs to keep track of explorer and taskbar changes, it is required for restoring wallpaper from crash and pause algorithm.