search

rocksdanister / lively

Free and open-source software that allows users to set animated desktop wallpapers and screensavers powered by WinUI 3.
https://rocksdanister.com/lively
GNU General Public License v3.0
15k stars 1.06k forks source link

Unable to use floats as slider step in LivelyProperties.json #525

Closed elias123tre closed 3 years ago

elias123tre commented 3 years ago

Describe the bug When setting the step value for a slider to a floating point number in LivelyProperties.json, it is received as the number but without the decimal. Example 4.5 gets received as 45. This does only happen when changing the value, it does not occur when first reloading the wallpaper.

To Reproduce Steps to reproduce the behavior:

  1. Download my project file
  2. Add and apply it in lively
  3. Change Background blur customization option (used as an example)
  4. See the received value in the upper left of the wallpaper as text

Expected behavior A decimal number should be received as such.

Screenshots/Video https://user-images.githubusercontent.com/18127101/119812593-97004700-bee8-11eb-8463-1400001e9b61.mp4

Desktop (please complete the following information):

Log file lively_log_20210527_123302.zip

rocksdanister commented 3 years ago

Not happening for me.. I think the copy file of properties is not getting updated. Few things to try:

  1. Restore defaults
  2. Can you try exporting the project .zip, deleting and adding it again.
elias123tre commented 3 years ago

Tried both the tings you said with no success. The problem remains even after deleting and adding the wallpaper and restoring defaults. The issue may be in my installation but how can I fix it?

rocksdanister commented 3 years ago

Share the folder with the same name as the problem wallpaper folder from the data location: C:\Users\<UserName>\AppData\Local\Lively Wallpaper\wpdata

elias123tre commented 3 years ago

From: C:\Users\Elias\AppData\Local\Lively Wallpaper\Library\SaveData wpdata.zip

rocksdanister commented 3 years ago

I need the foldername of your audio visualiser wallpaper.

elias123tre commented 3 years ago

Latest one is 2ndhq03m.he3 after I reinstalled the wallpaper. Before that it was gfesoybw.ydw

rocksdanister commented 3 years ago

The span configuration in gfesoybw.ydw is old copy:

  "bgBlur": {
    "max": 10,
    "min": 0,
    "tick": 25,
    "step": 1,
    "text": "Background image blur",
    "type": "slider",
    "value": 0
  },

Rest looks fine, the file of reinstalled wallpaper looks updated. Just for good measure can you try deleting the wpdata folder and restarting Lively.

elias123tre commented 3 years ago

Ok, will try that.

elias123tre commented 3 years ago

Tried it and it still doesn't work 😞

The duplicate LivelyProperties.json in new wpdata folder contains:

[...]
"bgBlur": {
    "max": 10,
    "min": 0,
    "step": 0.5,
    "text": "Background image blur",
    "type": "slider",
    "value": 2.5
  },
[...]
rocksdanister commented 3 years ago

Yeah I figured it out, its your regional format - English (Sweden) Fractions are separated by comma; Lively application is region aware but browser program is set to invariant culture.

elias123tre commented 3 years ago

Ah! A miracle that you figured it out. I wouldn't have thought of that. Looking forward to a fix in the next update 😄! And yes, it is because Sweden uses comma for decimal separation.

rocksdanister commented 3 years ago

Try the latest beta build to see if its fixed: https://github.com/rocksdanister/lively-beta/releases

elias123tre commented 3 years ago

It works now! Thanks!

Just want to say I love the lively app and this community. Thanks for listening and fixing things for us end users!