search

rocksdanister / weather

Windows native weather app powered by DirectX12 animations
https://rocksdanister.com/weather
MIT License
393 stars 21 forks source link

Notifications! #66

Open SpeedyCraftah opened 3 months ago

SpeedyCraftah commented 3 months ago

Would be great if you could configure it so that you received notifications about the current, and upcoming weather like Window's MSN weather app. I'd be happy to submit a PR for this when I have some spare time, although I'm not sure about adding an entry for it in the settings since I've never worked with UI in C# for Windows, but I can probably figure it out. It would also likely have to run in the background in the task bar, or at least a minimal separate process so that it can actually pull updates and display them in notifications.

rocksdanister commented 3 months ago

I am not sure what is notification, can you show a screenshot?

SpeedyCraftah commented 3 months ago

I am not sure what is notification, can you show a screenshot?

I mean the Windows notifications! Here is how they look from the Microsoft weather app: image

rocksdanister commented 2 months ago

Ah I see.

One issue I see is that currently the cache and weather fetch code is run from the main app, for background notification there needs to be background service and it will probably need to run it https://github.com/rocksdanister/weather/issues/3

SpeedyCraftah commented 2 months ago

Ah I see.

One issue I see is that currently the cache and weather fetch code is run from the main app, for background notification there needs to be background service and it will probably need to run it https://github.com/rocksdanister/weather/issues/3

That shouldn't be an issue, there's many ways we could do this. We could have a separate program running that starts on windows startup (should user allow it) which will run in background and update the weather cache as well as giving upcoming weather notifications, or we could make a service but don't know if services can send notifications. Either way we should keep it as simple as possible.

We could probably also keep it in the main program, but add an option to hide or show the UI which should also free up resources associated with it. The periodic weather updates and notifications can run on a separate thread.