[New Feature] Shared Recycle bin on samba shares

rockstor / rockstor-core

Linux/BTRFS based Network Attached Storage(NAS)

http://rockstor.com/docs/contribute_section.html

GNU General Public License v3.0

558 stars 138 forks source link

[New Feature] Shared Recycle bin on samba shares #1467

Open MFlyer opened 8 years ago

MFlyer commented 8 years ago

Reference to this forum thread.

User davioxx asking for samba recycle bin (https://www.samba.org/samba/docs/man/manpages/vfs_recycle.8.html) available in Rockstor Web UI (user friendly version, 0 lines custom params code conf) Shares recycle bin tasks list:

[ ] Modify samba shares model & provide migration (not in samba share custom config, boolean field like shadow copies field) [storageadmin/models/samba_share]
[ ] Modify samba shares view [storageadmin/views/samba]
[ ] Modify samba backbone view & template [storageadmin/static/storageadmin/js/ - add_samba_export.{js, jst}]
[ ] Refactor smb.conf building to have multiple vfs objects (move from one line code vfs writing to a vfs objects object to push objects to [system/samba.py]

MFlyer commented 8 years ago

Hi, samba recycle bin can be on a per share basis or like a global param (having only one recycle bin).

Considering Rockstor nature (btrfs nas) - imho - better to have recycle bins defined on a per share basis (1 common recycle byn would require defining where to have it: on Rockstor root?? i don't like this idea; on a random btrfs share?? noo)

MFlyer commented 8 years ago

Hi @schakrava , hoped to have this before next stable, but having some tests made me decide for a longer testing, here my reasons: testing over a Rockstor integrated in an AD environment found a strange behavior and some minor checks required (ex. : on a Rockstor share creation we set owner and group, new files&folders samba share to that share don't inherit permissions on creation - thought it was already ok). Having a recycle bin non accessible from users?? Ok, let's have it 200 (only write perm for owner)...no, samba recycle bin requires x too, so 300 :confused:

Addendum: our samba shares config currently missing, so pool/share acl not inherited

inherit owner = yes
inherit acls = yes

Every user should set it, but we could do it to, do you agree on having #1481 issue?