search

rockstor / rockstor-core

Linux/BTRFS based Network Attached Storage(NAS)
http://rockstor.com/docs/contribute_section.html
GNU General Public License v3.0
550 stars 137 forks source link

Upgrade bootstrap js/css #2548

Open kanecko opened 1 year ago

kanecko commented 1 year ago

Issue (correctly placed) in rockstor-jslibs: https://github.com/rockstor/rockstor-jslibs/issues/30

Upgrading bootstrap to at least 4.6 would be nice. The license and supported browsers look fine.

Reasoning: it has built-in switches. This means we could remove the dependency to external bootstrap-switch library. Cons: there will be breaking changes (https://getbootstrap.com/docs/4.6/migration/, https://getbootstrap.com/docs/5.2/migration/)

My opinion: since v3.x works fine with latest modern browsers, there is no rush to upgrade. Therefore it is a nice-to-have, but alas a low-prio task.

phillxnet commented 1 year ago

@kanecko Thanks for creating this issue. Lets try and get this sorted once we have our current Milestone sorted and have then kicked off the next testing channel stint. That way we can handle the inevitable breakage more easily: breakage is more acceptable in earlier testing channel.

Also agreed on good idea to reduce dependencies, we have them all over the place at the moment. Would you mind making a companion issue to this (linked between them) in our jslibs repo: https://github.com/rockstor/rockstor-jslibs And from my recent audit there I think bootstrap-switch is now one of our oldest dependencies, and likely no longer maintained. So it would be grand to drop that as soon as we can.

I'm not sure but this issue seems like it could be a can of worms, but never-the-less it would be great to get us upgraded as resources allow.

kanecko commented 1 year ago

Hah, I see there are yet more bootstrap plugins. Indeed it will surely be a can of worms...