search

rockstor / rockstor-core

Linux/BTRFS based Network Attached Storage(NAS)
http://rockstor.com/docs/contribute_section.html
GNU General Public License v3.0
556 stars 137 forks source link

Remove legacy files #2891

Open phillxnet opened 2 months ago

phillxnet commented 2 months ago

By way of preperation for our next Stable rpm release, it is proposed that we do a little house-keeping regarding some old legacy files, such as those dating back to pre rockstor-jslibs times. An example in this case would be the long defunct Django admin override files found in:

Removing their interference with now way newer .venv files from our current Django:

phillxnet commented 2 months ago

We also have some related clean-up regarding the movement of some CSS files, in rockstor-core, that are associated with JS counterparts in rockstor-jslibs; where we already have JS/CSS sets associated with projects such as:

E.g.:

bootstrap-*

./src/rockstor/storageadmin/static/storageadmin/css/bootstrap-editable.css:* Copyright (c) 2013 Vitaliy Potapov; Licensed MIT */
./src/rockstor/storageadmin/static/storageadmin/css/bootstrap-editable.css: * Copyright 2012 Stefan Petre
./src/rockstor/storageadmin/static/storageadmin/css/bootstrap-switch.min.css: * Copyright 2012-2013 Mattia Larentis
./src/rockstor/storageadmin/static/storageadmin/css/bootstrap-timepicker.css: * Copyright 2013 Joris de Wit
./src/rockstor/storageadmin/static/storageadmin/css/bootstrap.min.css: * Copyright 2011-2015 Twitter, Inc.
./src/rockstor/storageadmin/static/storageadmin/css/datepicker.css: * Copyright 2012 Stefan Petre

i.e. we have bootstrap associated JS files in rockstor-jslibs repo, but their associated bootstrap CSS files are in rockstor-core! Ergo remove from rockstor-core said CSS files and re-partner them with their associated JS files in rockstor-jslibs.

Font-awesome

Similarly, re re-location candidate, we have, in rockstor-core, font-awesome-4.7.0:

./src/rockstor/storageadmin/static/storageadmin/css/font-awesome-4.7.0/css
./src/rockstor/storageadmin/static/storageadmin/css/font-awesome-4.7.0/fonts

See also: "Post Poetry Milestone: Font Awesome upgrade consideration" #2537

Which would, in turn, have to move to rockstor-jslibs post the proposed removal, from rockstor-core, re-location to rockstor-jslibs.