search

rockstor / rockstor-iso

scripts and files to create Rockstor iso file
18 stars 10 forks source link

Move from docker-engine to docker-ce #21

Closed wingrunr21 closed 6 years ago

wingrunr21 commented 7 years ago

Docker engine was announced to be succeeded by Docker CE in June. It'd be great to start thinking about upgrading the Rockstor docker requirement to match the new alignment. The 1.13.x are scheduled to be EOL in February 2018 so moving over to CE before that would be great.

I haven't fully put it through its paces, but it looks like switching would be a matter of switching Rockstor's dependency from docker-engine to docker-ce, uninstalling existing versions, and upgrading. The Docker package repository would also need to be set up in the system.

CentOS instructions

Sorry if this is the wrong repo for this issue. Only place I could find a reference to docker-engine itself is here.

phillxnet commented 6 years ago

@wingrunr21 Looks like this issue is now resolved by way of it's sister issue linked: https://github.com/rockstor/rockstor-core/issues/1860 in the rockstor-core repo so I suggest this issue be closed as a duplicate of: https://github.com/rockstor/rockstor-core/issues/1860 Thanks.

wingrunr21 commented 6 years ago

Yep, agreed. Thanks!