search

rocky-linux / infrastructure

The infrastructure monorepo for the Rocky Linux project. This project will be archived/deprecated in the future.
https://rockylinux.org
386 stars 46 forks source link

fix: use rocky_version variable to template rocky_iso_download_url #15003

Closed hbjydev closed 9 months ago

tcooper commented 2 years ago

@hbjydev We might want a tweak to what you've provided here. I believe it's preferable to use only the MAJOR version in that part of the URL and I've seen cases where using MAJOR.MINOR can cause issues. @NeilHanlon can you comment/confirm/review?

NeilHanlon commented 2 years ago

Correct. would be good to make sure we're using the major version only here.

hbjydev commented 2 years ago

My issue with that is that you guys are also inserting the checksums. Surely that means that on a new image being released, the playbook(s) using this file would just stop working?

if that’s not a concern or anything then fair enough, I can tweak.

tcooper commented 2 years ago

It's true, for each new release we must update the data used by the playbook. Unless we implement a pull of the CHECKSUM file, verify the GPG sig and then use the contents this is what is required. We've had issues with bad (cached) ISOs at various times the CHECKSUM validation prevents those from creeping in.