search

rocky-linux / peridot

Cloud-native build and release tools tailored to building, releasing and maintaining Linux distributions and forks
https://peridot.build.resf.org
BSD 3-Clause "New" or "Revised" License
146 stars 32 forks source link

fix: display build subtask timing properly regardless of location #161

Open NeilHanlon opened 7 months ago

NeilHanlon commented 7 months ago

full disclosure i don't know how this new fangled javascript crap^Wstuff works and if I need to export that function, but.. i expect not based on Logic and Reason

PlaidCat commented 7 months ago

full disclosure i don't know how this new fangled javascript crap^Wstuff works and if I need to export that function, but.. i expect not based on Logic and Reason

I'm sufficiently happy with this. For record when looking at duration on a kernel build it would say 6:24:00PM as the build time but the EastCoast is -5hr from UTC, the -360000 would then subtract another hour which is how the offset would arise.

/approve

resf-prow[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NeilHanlon, PlaidCat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/rocky-linux/peridot/blob/main/OWNERS)~~ [NeilHanlon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
resf-prow[bot] commented 6 months ago

@NeilHanlon: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-peridot-non-manual-build 6ab449e4f58f7236f733eeadcd435a5f4e38fc8f link true /test pull-peridot-non-manual-build
pull-peridot-build-impacted-frontend 6ab449e4f58f7236f733eeadcd435a5f4e38fc8f link true /test pull-peridot-build-impacted-frontend
pull-peridot-unit-test 6ab449e4f58f7236f733eeadcd435a5f4e38fc8f link true /test pull-peridot-unit-test
pull-peridot-gofmt-check 6ab449e4f58f7236f733eeadcd435a5f4e38fc8f link true /test pull-peridot-gofmt-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).