search

rocky-linux / rocky-tools

MIT License
401 stars 139 forks source link

Add OpenELA lookaside to getsrc #206

Closed maxbyte9p closed 10 months ago

maxbyte9p commented 10 months ago

OpenELA's lookaside can be added to the getsrc grabber with minimal modification. I have also confirmed that the modified grabber works with OpenELA's lookaside.

pajamian commented 10 months ago

The lookaside is great but we should also have the remotes glob so that getsrc can find the correct lookaside without having to try all the other ones first. What are the http and git remote URLs for OpenELA?

maxbyte9p commented 10 months ago

The lookaside is great but we should also have the remotes glob so that getsrc can find the correct lookaside without having to try all the other ones first. What are the http and git remote URLs for OpenELA?

I will have to look into that. I also noticed that there is a branches section in the grabber for glob matching those. It's likely a good idea to add glob matches for the OpenELA branches as well. The OpenELA branches for example are named el-x.x

maxbyte9p commented 10 months ago

The lookaside is great but we should also have the remotes glob so that getsrc can find the correct lookaside without having to try all the other ones first. What are the http and git remote URLs for OpenELA?

I will have to look into that. I also noticed that there is a branches section in the grabber for glob matching those. It's likely a good idea to add glob matches for the OpenELA branches as well. The OpenELA branches for example are named el-x.x

'@(git@|http?(s)://)github.com/openela-main/*'

This is a working glob match for https cloned OpenELA repositories. As for ssh cloned I haven't gotten that figured out yet.

pajamian commented 10 months ago

I also noticed that there is a branches section in the grabber for glob matching those. It's likely a good idea to add glob matches for the OpenELA branches as well. The OpenELA branches for example are named el-x.x

The branches only need to be matched if each branch has a different lookaside URL. If the lookaside is the same for all the branches then there's no need to match the branch.

maxbyte9p commented 10 months ago

I also noticed that there is a branches section in the grabber for glob matching those. It's likely a good idea to add glob matches for the OpenELA branches as well. The OpenELA branches for example are named el-x.x

The branches only need to be matched if each branch has a different lookaside URL. If the lookaside is the same for all the branches then there's no need to match the branch.

That makes sense. Thank you for informing me of that.

maxbyte9p commented 10 months ago

The lookaside is great but we should also have the remotes glob so that getsrc can find the correct lookaside without having to try all the other ones first. What are the http and git remote URLs for OpenELA?

I will have to look into that. I also noticed that there is a branches section in the grabber for glob matching those. It's likely a good idea to add glob matches for the OpenELA branches as well. The OpenELA branches for example are named el-x.x

'@(git@|http?(s)://)github.com/openela-main/*'

This is a working glob match for https cloned OpenELA repositories. As for ssh cloned I haven't gotten that figured out yet.

'@(git@|http?(s)://)github.com[:/]openela-main/*'

I got a working glob match for both https and ssh cloned OpenELA repositories.

maxbyte9p commented 10 months ago

I committed the OpenELA glob pattern to my fork. Is there anything else that needs to be done?

pajamian commented 10 months ago

Just add another blank entry to the branches array so it maintains parity with the other arrays.

maxbyte9p commented 10 months ago

Just add another blank entry to the branches array so it maintains parity with the other arrays.

Done.

NeilHanlon commented 10 months ago

Thank you @pajamian and @maxbyte9p !

maxbyte9p commented 10 months ago

@pajamian @NeilHanlon No problem!