search

rocky-linux / sig-cloud-instance-images

47 stars 7 forks source link

Images should have annotations/labels #20

Open NeilHanlon opened 2 years ago

NeilHanlon commented 2 years ago

Originally removed per request by Docker Hub official images team.

Background

The images we first published had labels on them with some information. This was removed when going to the Library images because the label-schema spec being used was deprecated. I opted to simply remove all the labels and revisit it at a future time.

Labels

Previously, the container had labels such as:

    org.label-schema.name="Rocky Linux Base Image" \
    org.label-schema.vendor="Rocky Enterprise Software Foundation" \
    org.label-schema.license="BSD-3-Clause" \
    org.label-schema.build-date="20210620" \
    org.opencontainers.image.title="Rocky Linux Base Image" \
    org.opencontainers.image.vendor="Rocky Enterprise Software Foundation" \
    org.opencontainers.image.licenses="BSD-3-Clause" \
    org.opencontainers.image.created="2021-06-20 00:00:00+01:00"

The label-schema annotations are now deprecated: superseded by the OCI image specification standard: https://github.com/opencontainers/image-spec/blob/v1.0.1/annotations.md

We should look and add any labels we think would be helpful, with particular mind to SBOM. This will be automated and generated as part of the image build pipeline.

NeilHanlon commented 1 year ago

@lumarel we might want to integrate this, maybe