rocky / Perl-Devel-Callsite

Get caller Perl OP address
https://metacpan.org/pod/Devel::Callsite
2 stars 2 forks source link

Include ppport.h 3.35 which provides caller_cx for us #4

Closed wolfsage closed 7 years ago

wolfsage commented 7 years ago

ppport.h is not supposed to be generated on the fly from whatever version of Devel::PPPort is lying around - it should be generated by the developer and included with the project as things may change causing breakages.

In this case, 3.25 started including its own caller_cx which broke Devel::Callsite for perls that don't have it like 5.10.1.

(See https://github.com/mhx/Devel-PPPort/issues/48)

rocky commented 7 years ago

Thanks for the bug report and fix. I'm not sure I totally understand after rereading this and the links several times, but you seem to know more about what you're doing than I and the current tests don't break with this.

rocky commented 7 years ago

@wolfsage although when I tested this from pulling from your repo, I now get this error after the merge:

$ perl Makefile.PL
Generating a Unix-style Makefile
Writing Makefile for Devel::Callsite
Writing MYMETA.yml and MYMETA.json
$ make
Skip blib/lib/Devel/Callsite.pm (unchanged)
Skip blib/lib/Devel/README.pod (unchanged)
Running Mkbootstrap for Devel::Callsite ()
chmod 644 "Callsite.bs"
x86_64-linux-gnu-gcc -c   -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -O2 -g   -DVERSION=\"0.09\" -DXS_VERSION=\"0.09\" -fPIC "-I/usr/lib/x86_64-linux-gnu/perl/5.22/CORE"   Callsite.c
Callsite.xs:7:20: fatal error: ppport.h: No such file or directory
compilation terminated.
Makefile:337: recipe for target 'Callsite.o' failed
make: *** [Callsite.o] Error 1
$ git pull
Already up-to-date.

What gives?

wolfsage commented 7 years ago

If there's any questions you have I'm happy to try to answer them.

As to the error you're seeing... I'm not sure. Does ppport.h exist?

What does git status say? Have you tried git clean -dfx (after making sure there's no important files lying around).

wolfsage commented 7 years ago

Ah, I see, Make clean kills off ppport.

Pushed one more commit to my branch, sorry!

commit 823a14656fe96e5a0660eff515632b29cd39e8ab Author: Matthew Horsfall (alh) wolfsage@gmail.com Date: Thu Mar 16 12:39:19 2017 -0400

Remove PPPort dep and cleaning from Makefile.PL
rocky commented 7 years ago

Would you then submit another merge request?

wolfsage commented 7 years ago

Sure