rocky / python-uncompyle6

A cross-version Python bytecode decompiler
GNU General Public License v3.0
3.82k stars 410 forks source link

List comprehensions inside of a lambda print only `[` #492

Open JorianWoltjer opened 8 months ago

JorianWoltjer commented 8 months ago

Description

List comprehensions inside of a lambda print a single [ bracket instead of the list comprehension, resulting in invalid syntax.

How to Reproduce

The following is a simple list comprehension in a lambda function:

# fmt:off
a = lambda n: [i + 1 for i in range(n)]

Stored in a file called poc.py, it can be compiled into a .pyc file with the following commands:

python3 -c 'import py_compile; print(py_compile.compile("poc.py"))'

uncompyle6 __pycache__/poc.cpython-38.pyc 

It decompiles to the following code on the latest 3.9.1 version:

# Size of source mod 2**32: 50 bytes
a = lambda n: [

# okay decompiling __pycache__/poc.cpython-38.pyc

This happens while a regular function using def containing a list comprehension does work perfectly:

def a(n):
    return [i + 1 for i in range(n)]

Expected behavior

Write the whole list comprehension just like a function using def would. This would be the expected output for the example above:

a = lambda n: [i + 1 for i in range(n)]

Environment

$ uncompyle6 --version
uncompyle6, version 3.9.1
$ pydisasm --version
pydisasm, version 6.1.0
$ python3 -c "import sys; print(sys.version)"
3.8.10 (default, Nov 22 2023, 10:22:35) 
[GCC 9.4.0]
$ cat /etc/issue
Ubuntu 20.04.6 LTS

Workarounds

Ignore the missing list comprehension code in the output, because it continues to print the code after it. This won't make the code inside the list comprehension visible though.

rocky commented 8 months ago

This is a bug in the print action routines (probably uncompyle6/semantics/gencomp.py) that take the AST produced and format and print the results. You can see the trees that get created by adding the -T option to uncompyle6.

A like kind of thing that happens is that the wrong child of a node is looked at in the generation routine.

This works in decompyle3, so one fix would be to backport code from there here.

Are you up for fixing this bug?

JorianWoltjer commented 8 months ago

Thanks for the comment, I had not seen decompyle3 before and it does seem to work there! I'll try switching to that repository as I am working on Python 3.8.

I'm personally not up to the task of fixing it, especially now that I have a clean workaround, but maybe a backport can happen one day indeed.

mosadegh22 commented 8 months ago

One of the problems when decompile in list Comprehension and result is : parents = (lambda .0: [ Nodes.getParent(x) for x in .0 ])(nodes) and In some cases, it outputs an empty file In one case, a 60KB file became 120MB.had repeated in python 3.7 and decompyle6

rocky commented 8 months ago

@mosadegh22 file a proper bug report in decompyle3 and I might investigate when I am able.