rocky / remake

Enhanced GNU Make - tracing, error reporting, debugging, profiling and more
http://bashdb.sf.net/remake
GNU General Public License v3.0
785 stars 73 forks source link

Failing to run tests #117

Closed SCOTT-HAMILTON closed 3 years ago

SCOTT-HAMILTON commented 3 years ago

Hello, I'm updating the remake package of NixOS and a good practice is to run as much tests as possible, especially those provided by the package. So I tried to run make check but I get the following error :

variables/INCLUDE_DIRS .................................. FAILED (1/2 passed)
[...]

1 Test in 1 Category Failed (See .diff* files in work dir for details) :-(

And the diff file content tests/work/variables/INCLUDE_DIRS.diff is :

*** work/variables/INCLUDE_DIRS.base    Sat Apr 17 17:51:23 2021
--- work/variables/INCLUDE_DIRS.log Sat Apr 17 17:51:23 2021
***************
*** 0 ****
--- 1 ----
+ work/variables/INCLUDE_DIRS.mk:3: .INCLUDE_DIRS is empty
rocky commented 3 years ago

The same test is run on MacOS and and Ubuntu. See https://travis-ci.org/github/rocky/remake/builds/738502192 for example. So it is possible that there is a problem with this test on NixOS.

This test comes from GNU Make, and some of their tests are flaky. Does the equivalent version of GNU Make succeed?

SCOTT-HAMILTON commented 3 years ago

I have the same issue with GNU Make

rocky commented 3 years ago

Ok. Since we are compatible with GNU Make this isn't a bug, but a compatability feature.