search

roclark / sportsipy

A free sports API written for python
MIT License
482 stars 188 forks source link

Update all test files #483

Open roclark opened 3 years ago

roclark commented 3 years ago

Is your feature request related to a problem? Please describe. Many of the saved test files are very out of date at this point, and are as much as 3 years old. The website has changed a fair amount over the years and plenty of new features have been added. To capture these latest features, the default test files should be updated with newer content, which would also require updating the pre-defined values in the test files.

Describe the solution you'd like The files in all of the various folders should be changed with a pull from current data. For example, the current MLB Boxscore test file should be replaced with a newer version of a game that took place this season. The pre-defined results data should be updated with the new stats in order to pass the tests.

Describe alternatives you've considered The data could still work as-is with the old data, but it doesn't offer the best opportunity to continually push and expand the package as the website progresses.

Additional context This can be done over multiple PRs (ie. one per sport, or one per module), or in a single shot. Regardless of the number, the layout of the commits and PRs should look very similar to one-another.

thomaslu2 commented 3 years ago

Hey can I work on this?

roclark commented 3 years ago

Hey @thomaslu2, of course! 😃 That would be wonderful! Let me know if you would like any support on the process, and I'd be happy to help out!