roclark / sportsipy

A free sports API written for python
MIT License
484 stars 187 forks source link

Fix the fumbles_recovered_for_touchdown stat. #638

Closed kjsr7 closed 2 years ago

kjsr7 commented 3 years ago

For both yards_recovered_from_fumble and fumbles_recovered_for_touchdown, same stat fumbles_rec_yds is being populated. Hence, renaming fumbles_rec_yds to fumbles_rec_td for fumbles_recovered_for_touchdown.

Issue Example from sportsipy.nfl.teams import Schedule Schedule('CAR', 2020)[11].boxscore.away_players[11].dataframe.reset_index()[['index', 'yards_recovered_from_fumble', 'fumbles_recovered_for_touchdown']]

Ouput: Screenshot 2021-07-24 at 9 42 46 AM

But actual fumbles_recovered_for_touchdown for ChinJe00 (Jeremy Chinn) in the https://www.pro-football-reference.com/boxscores/202011290min.htm is 2 as shown below in the screenshot

Screenshot 2021-07-24 at 9 44 35 AM

In the inspect of https://www.pro-football-reference.com/boxscores/202011290min.htm page, it can be seen that the fumbles_recovered_for_touchdown can be obtained using fumbles_rec_td (below screenshot)

image

closes #629

roclark commented 2 years ago

Closing as this is now resolved.