roclark / sportsipy

A free sports API written for python
MIT License
475 stars 189 forks source link

Unable to get names of MLB players #712

Open moegoldberg opened 2 years ago

moegoldberg commented 2 years ago

Describe the bug I tried to get the names of all of the players on the 1956 Dodgers, and they are all listed as None, I then tried to get the name of a few individual players, and they were all None

To Reproduce Sample code which causes an issue.

>>> from sportsipy.mlb import teams
>>> t = teams.Teams(1956)
>>> t['BRO'].roster.players
[None (camparo01), None (hodgegi01), None (gilliji01), None (reesepe01), None (jacksra01), None (amorosa01), None (snidedu01), None (furilca01), None (robinja02), None (walkeru01), None (nealch01), None (nelsoro01), None (fernach01), None (cimolgi01), None (mitchda01), None (zimmedo01), None (howeldi02), None (willidi02), None (demetdo01), None (asprobo01), None (newcodo01), None (maglisa01), None (craigro01), None (erskica01), None (drysddo01), None (labincl01), None (bessedo01), None (koufasa01), None (roebued01), None (lehmake01), None (templch01), None (hugheji02), None (brancra01), None (darnebo01), None (loesbi01)]
>>> print(t['BRO'].roster.players[0].name)
None
>>> from sportsipy.mlb.roster import Player
>>> print(Player('camparo01').name)  # Roy Campanella
None
>>> print(Player('koufasa01').name)  # Sandy Koufax
None
>>> print(Player('bondsba01').name) # Barry Bonds
None

Expected behavior Successfully print the players names

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):