davidjkrause
commented
1 month ago As with most recent issues here, this should be resolved by the fork at https://github.com/davidjkrause/sportsipy
There was a fair amount of work done on that fork to get every base test to pass, since so many were failing when I started using the package.
See my similar comment on most of the recent issues, this particular repo seems no longer maintained.
Describe the bug I went ahead and ran the unit tests to verify that they were functioning properly and found that the file test_nhl_roster.py failed one of the tests it was supposed to pass due to improper error handling. The error seems to be that the test expects the method player._retrieve_html_page() to return None, but instead, it's returning a list containing an HTML paragraph element ([
]). This mismatch between expected and actual outputs leads to the assertion failure.
To Reproduce run the test_nhl_roster.py file.
Expected behavior I expected to see both tests pass.
Desktop (please complete the following information):