search

roclark / sportsipy

A free sports API written for python
MIT License
475 stars 189 forks source link

Update test_nhl_roster.py #795

Open SDL101 opened 1 month ago

SDL101 commented 1 month ago

Fix failing NHL unit test

The file test_nhl_roster.py failed one of the tests. The error seems to be that the test expects the method player._retrieve_html_page() to return None, but instead, it's returning a list containing an HTML paragraph element ([

]). Mismatch between expected and actual outputs leads to the assertion failure.

Signed-Off-By: Scott lindsasc@oregonstate.edu

Pull Request template

Please, go through these steps before you submit a Pull Request (PR).

  1. Make sure that your PR is not a duplicate.
  2. If not, then make sure that:
    • You have done your changes in a separate branch.
    • Your PR is specific to one change or theme and doesn't entail many different unrelated updates.
    • You have a descriptive commit message with a short title (first line).
    • Unless otherwise necessary, you have only commit.
    • If new features or code has been added, proper tests for the new functionality are included.
    • Additional code or changes to the existing code are properly documented in the docs/ directory when appropriate.
  3. After these steps, you're ready to open a PR.
    • Give a descriptive title to your PR.
    • Provide a description of your changes.
    • Put closes #XXXX in your comment to auto-close any issue(s) your PR resolves, if applicable.

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing and styling guidelines.

PLEASE REMOVE THIS TEMPLATE PRIOR TO SUBMITTING THE PULL REQUEST