search

roclin-grp / roclin-grp.github.io

Company Site with GitHub Pages
0 stars 0 forks source link

Feat/39 index carousel #41

Closed mavstronaut closed 6 years ago

mavstronaut commented 6 years ago

Fixed base.

Issue #39

Made some minor tweaks to styling. Still has cleaning up to be done, but in working on this I think I know how I want things to look more clearly.

Obviously, the copy and everything will be focused and honed over time, but I wanted to get some content that might fit the bill to see how the pages would flow approximately.

Played around in paint to work up a logo concept that should do for now. resized it a few times but didn't change the favicons as it is a minor detail for another hour.

The images issue is still an open question, and proper configuration so that the carousel images point to the images folder and not /blog/*.png

loljoho commented 6 years ago

Oops, I messed up with the Request Review feature of GitHub which is relatively new, and with which I'm not quite familiar yet.

Make sure you look over all the comments I made, and not just the 3 or so that are part of the "requested changes", and push new commits accordingly.

Cheers :)

loljoho commented 6 years ago

I only see one new commit 1b09a26. Are you still working on this?

loljoho commented 6 years ago

Eschewing strict and proper workflow to get this finished.

Closes: #39