search

rocmarchive / realcaffe2

The repo is obsolete. Use at your own risk.
https://github.com/pytorch/pytorch
Apache License 2.0
12 stars 2 forks source link

Investigate and fix compiler warning from operator.h [-Winconsistent-missing-override] #11

Closed petrex closed 6 years ago

petrex commented 6 years ago

/home/pyeh/Projects/rocm_caffe2/caffe2/core/operator.h:347:8: warning: 'WaitEvent' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void WaitEvent(const Event& ev, int stream_id = -1) final {

petrex commented 6 years ago

The error comes from upstream files. (when compiled with hipcc->clang6.0) Plan to disable this check in the make file. We will review the makefile , especially the HIP path; migrate to modem cmake if possible.

petrex commented 6 years ago

104