rocmarchive / realcaffe2

The repo is obsolete. Use at your own risk.
https://github.com/pytorch/pytorch
Apache License 2.0
12 stars 2 forks source link

Hipify operator #22

Closed petrex closed 6 years ago

petrex commented 6 years ago

@ashishfarmer I split the hipified ops to mini- batch so we could work together.

Note : It could require extra effort to compile and validate the ops. But we could focus on one commit per sprint, make it build and validated before pushing to AMD_develop. ( or make other adjustments to the mini-batch, like prioritize certain ops, etc)

ashishfarmer commented 6 years ago

I like this approach, a good way to divide the work. One comment I have about the files you changed - let us get rid of the legal license all together in all the files we change. In this way we can add the statement once we get one from the legal into our code and that will be an easy change.

ashishfarmer commented 6 years ago

Does the branch in it's current state and initial hipification build?

petrex commented 6 years ago

I believe so. But pls help verify that as well.

petrex commented 6 years ago

let's merge this into for now

hipify_operator

the next will be creating the separate branch from the single commits, validate the ops and merge back to

AMD_develop