search

rocs-org / data-pipelines

Data engineering monorepo with Airflow, dbt and postgres
https://ornt.biologie.hu-berlin.de/airflow
4 stars 1 forks source link

Add linnting, isort and black as pre commit hooks #78

Open jakobkolb opened 2 years ago

jakobkolb commented 2 years ago

To avoid unnecessary CI failures, do code formatting automatically. Also, run linting and reject commit if linting does not pass.

benmaier commented 2 years ago

how does automatic formatting work? is there a vim plugin?

jakobkolb commented 2 years ago

Well maybe there is a vim plugin, i wouldn't know. My preferred way is to install a formatter (I like black) and then, in your project directory, just run black .

benmaier commented 2 years ago

amazing, thanks

davhin commented 2 years ago

I have done black+flake8 pre-commit hook in the datenspende repo, I can take over this task