search

roddeh / i18njs

Internationalisation library for JS projects
MIT License
64 stars 17 forks source link

[Idea] CI with Travis #12

Open marverix opened 5 years ago

marverix commented 5 years ago

How about integration with Travis? Whenever someone will create PR, Travis would run tests - so you will know if it's safe to merge it or not? :)

roddeh commented 5 years ago

I am not familiar with Travis. Generally I am open to any improvements to tooling so long as they don't create hard dependencies (I am regretting CoffeeScript for example).

marverix commented 5 years ago

I'm using CS 1.x in my job (as when I came it was already used). Yes, it has it downsides, but for the time it was ok. I still like it. But if you regret having it in CS how about moving it to ES6, and as bundler using rollup.js + babel plugin (check my repo for example: https://github.com/marverix/rollup-plugin-copier ).

So how about this roadmap:

  1. Move tests to Mocha (#10).
  2. Move CoffeeScript to ES6.
  3. Run tests if we didn't brake anything.
  4. Add Linter (eslint) (#11)
  5. Add Travis (#12).
  6. Add husky (https://github.com/typicode/husky).

Ofc I will be glad to help you with above, especially that I'm using above technologies e.g. in repo that I mentioned above.

Br, Marek