roddhjav / pass-import

A pass extension for importing data from most existing password managers
https://www.passwordstore.org/
GNU General Public License v3.0
800 stars 88 forks source link

Update Python code for new clean signature #194

Closed ctrueden closed 1 year ago

ctrueden commented 1 year ago

The clean function now requires cmdclean and convert flags to be given.

Or you could keep backwards compatibility by adding default values:

def clean(self, cmdclean=True, convert=True):
ctrueden commented 1 year ago

Also, the line:

    with PasswordStore('~/.password-store') as exporter:

did not work for me as written. You could consider changing it to:

    with PasswordStore(os.path.expanduser('~/.password-store')) as exporter:

Or do that internally inside the PasswordStore class.

ctrueden commented 1 year ago

And thank you for this super useful tool! :beers:

roddhjav commented 1 year ago

Thanks a lot. Merged. And also sorry for the delay.