roddhjav / pass-import

A pass extension for importing data from most existing password managers
https://www.passwordstore.org/
GNU General Public License v3.0
806 stars 89 forks source link

Problems importing from 1password #23

Closed acroca closed 6 years ago

acroca commented 6 years ago

Hi,

I've run into some issues importing from 1 password:

But the main problem I have is with custom data. I have some entries in 1password with custom fields and they are not exported in the CSV (since they are freeform). I think the importer should use 1pif files instead of the CSV because they contain all data available and it looks easy to parse.

roddhjav commented 6 years ago

Hi, could you give me more information in order to help you.

I could add the support for 1pif file in the future.

acroca commented 6 years ago

That included all the fields managed by 1password, but not custom ones. For example, for website with security questions I add custom fields with the answers. For example, if they ask me about my dream job I have a field like dream job as a key and blah as a password value, and this field is not getting exported. 1pif has all fields, I feel is a much better choice.

roddhjav commented 6 years ago

So its seem guys at 1password are not able to have consistent csv header file. This header is completely different from the reference header used to test the import. See https://github.com/roddhjav/pass-import/blob/master/tests/db/1password.csv

Nevertheless, you are right 1pif seems to be a way better solution. However, it requires to add a bit of code, nothing to fancy, but I won't have the time to implement it before next month.

acroca commented 6 years ago

I ended up using kdbx (keepass) instead and I wrote a quick-and-dirty conversion script to convert from opvault to kdbx. I managed to get all the info out of 1password using my fork of https://github.com/miquella/opvault, a go library to read opvault files.

cfeckardt commented 6 years ago

I've begun working on implementing this. I have a sort of working implementation here:

https://github.com/cfeckardt/pass-import/tree/onepasswordpif

I'll try to finish it this week.

Don't judge my code too harshly, im not a python dev. It'll be cleaned up and niceified before a PR comes.

roddhjav commented 6 years ago

I had a look at your implementation, it seems to be a good start, do not hesitate to make a PR when you think its ready.

roddhjav commented 6 years ago

Fixed with pass-tomb 2.2