search

roddypratt / tallyview

TSL UMD Protocol Tally receiver/viewer
Other
12 stars 1 forks source link

Add TSL V5 support #1

Open roddypratt opened 4 years ago

roddypratt commented 4 years ago

Currently on 3.1 and 4 are handled

yboujraf commented 3 years ago

Dear @roddypratt

Any chance to support TSL 5.0 in TCP and UDP ?

I have attached the protocol.

TSL UMD Protocol.pdf

Best regards,

roddypratt commented 3 years ago

@yboujraf

Any chance to support TSL 5.0 in TCP and UDP ?

I've looked at it but the 5.0 spec is badly defined, e.g. no discussion of how packet lengths and DLE stuffing interact. I also don't have a "genuine" 5.0 sender to compare with.

If you can provide a Wireshark capture from a 5.0 system that would be really helpful.

yboujraf commented 3 years ago

Dear @roddypratt If you share your email, I will share the TSL5.0 udp/tcp emulator.

You will be able to generate the buffer with all flags.

Finally I could help you.

Best regards

roddypratt commented 3 years ago

@yboujraf - Thanks for the offer! I've actually just released V1.1.0 which includes support for V5.0 over UDP. Please let me know is you hit any issues.

yboujraf commented 3 years ago

Dear @roddypratt

I will be back in two weeks. Will let you know for sure if any issue .

Thanks again Best regards

kylemeenehan commented 6 months ago

Hi there, thanks for this great app!

If I'm reading the spec correctly though (https://tslproducts.com/media/1959/tsl-umd-protocol.pdf), the DLE/STX start sequence is only required over TCP/IP and other protocols, and is not required over udp.

However, the implementation here checks for the DLE/STX start even over udp.

Am I mistaken in my interpretation of the specification, or is a change required here?

I'm happy to open a PR that handles the difference between protocols if it's needed.