search

roddyyaga / ppx_rapper

Syntax extension for writing SQL in OCaml
Other
139 stars 18 forks source link

Async #9

Closed bikallem closed 3 years ago

bikallem commented 3 years ago

Hi,

Thanks for the nice library. Are you open to make this ppx/library compatible with async library in addition to lwt? It probably needs to be split into two packages, ppx_rapper-lwt and ppx_rapper.async ?

roddyyaga commented 3 years ago

Hey, I'd definitely be open to a PR to do that but probably won't get round to adding it myself in the near future.

bikallem commented 3 years ago

Thanks. I should be able to able to open a PR to implement this soonish.

bikallem commented 3 years ago

PR opened https://github.com/roddyyaga/ppx_rapper/pull/10

bikallem commented 3 years ago

Fixed by #10. Closing.