rode / grafeas-elasticsearch

An implementation of the Grafeas storage backend based on Elasticsearch
Apache License 2.0
12 stars 5 forks source link

fix implementation for ListNotes #21

Closed mrparkers closed 3 years ago

mrparkers commented 3 years ago

I didn't want to write integration tests for this without BatchCreateNotes being implemented, so I backfilled other integration tests instead.

codecov[bot] commented 3 years ago

Codecov Report

Merging #21 (e668ce1) into main (6eb5ef3) will increase coverage by 7.53%. The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   80.86%   88.40%   +7.53%     
==========================================
  Files           2        2              
  Lines         507      483      -24     
==========================================
+ Hits          410      427      +17     
+ Misses         76       34      -42     
- Partials       21       22       +1     
Impacted Files Coverage Δ
go/v1beta1/storage/elasticsearch.go 86.22% <87.87%> (+8.95%) :arrow_up:
go/v1beta1/storage/filtering/filtering.go 97.80% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6eb5ef3...e668ce1. Read the comment docs.