rode / grafeas-elasticsearch

An implementation of the Grafeas storage backend based on Elasticsearch
Apache License 2.0
12 stars 5 forks source link

Revert exposing ES types and pin goreleaser #39

Closed alexashley closed 3 years ago

alexashley commented 3 years ago

This PR reverts #38 -- depending on the storage package of grafeas-elasticsearch in Rode causes us to pull in a copy of Grafeas; which registers its protobuf declarations into the global registry and prints a bunch of warnings at app start:

[rode] 2021/02/18 17:22:07 WARNING: proto: message grafeas.v1beta1.Occurrence is already registered
[rode] A future release will panic on registration conflicts. See:
[rode] https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

The only way I can think to get around that would be to refactor grafeas-elasticsearch and extract some of the components into their own package that doesn't reference Grafeas. That would be a bigger effort than just duplicating the types for now.

Also in the process of releasing those changes, the pipeline publish action failed trying to build for Apple ARM, because goreleaser recently added support. This downgrades the version of goreleaser until they release a fix for Go 1.15.