search

rode / grafeas-elasticsearch

An implementation of the Grafeas storage backend based on Elasticsearch
Apache License 2.0
12 stars 5 forks source link

Last page token on paginated requests should be an empty string #72

Closed pickjasmine closed 3 years ago

pickjasmine commented 3 years ago

Closes #66

Also ups the PIT TTL to 5 minutes so anyone searching won't unexpectedly lose their spot in search unless they're really hanging out there.

related rode PR

codecov-commenter commented 3 years ago

Codecov Report

Merging #72 (3be45fb) into main (39f9e96) will decrease coverage by 0.08%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
- Coverage   82.62%   82.53%   -0.09%     
==========================================
  Files          10       10              
  Lines        1128     1134       +6     
==========================================
+ Hits          932      936       +4     
- Misses        124      125       +1     
- Partials       72       73       +1
Impacted Files Coverage Δ
go/v1beta1/storage/elasticsearch.go 83.27% <66.66%> (-0.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39f9e96...3be45fb. Read the comment docs.