Feat.status page - Githubissues

rodekruis / IBF-system

Tools required to trigger, manage and execute the Red Cross Early Action Protocols for natural disasters.

https://ibf.510.global

Apache License 2.0

12 stars 15 forks source link

Feat.status page #1565

Closed jannisvisser closed 1 month ago

jannisvisser commented 1 month ago

Describe your changes

PR for item #1520. Decided to implement this by making a separate page in portal itself, accessible through dev-menu.

Checklist before requesting a review

[x] I have performed a self-review of my code
[ ] I have added tests wherever relevant
[x] I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

Any helpful instructions or clarifications...

jannisvisser commented 1 month ago

@gulfaraz can I ask you for a code review? So not just functional review, but also have a look at how to best do it? (subscriptions/types/angular setup/duplication of code with other services?/etc) I am still getting back into the code a bit, and also in general it's good to try to improve on the current code quality.

jannisvisser commented 1 month ago

@gulfaraz I processed your comments. In some I left a question back to you. And added 2 extra commits not based on commits. I do consider the current version a potentially shippable version, so I marked this ready for review, and dragged the issue to Review column.