test: add user module unit test - Githubissues

rodekruis / IBF-system

Tools required to trigger, manage and execute the Red Cross Early Action Protocols for natural disasters.

https://ibf.510.global

Apache License 2.0

12 stars 15 forks source link

test: add user module unit test #1787

Closed arsforza closed 1 day ago

arsforza commented 1 week ago

closes #1603

Describe your changes

Brief description of your changes - not in-depth because the bulk of the description should be in the task on DevOps.

Checklist before requesting a review

[x] I have performed a self-review of my code
[x] I have added tests wherever relevant
[x] I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

@gulfaraz: @jannisvisser and I decided to add a test on generateJWT because:

other functionalities are already covered by API tests
the remaining non-tested methods in the service are just database calls and we felt they didn't need a unit test

jannisvisser commented 1 day ago

Merging this in andrea's absence @gulfaraz