rodekruis / shelter-database

MIT License
9 stars 5 forks source link

Updated deployment with pipenv and npm #35

Closed cedricbonhomme closed 6 years ago

cedricbonhomme commented 6 years ago

Mainly deployment improvements:

Minor fixes in runserver.py and in the default configuration file (the database name was missing).

Some other minor improvements may arrive.

arongergely commented 6 years ago

Hi Cédric, at 510/NLRC we are currently in the process of migrating the shelter database instance. Are the updates in your pull request tested/ ready to use? If so I would use this method to deploy the new instance. Regards, Aron

cedricbonhomme commented 6 years ago

Yes, I tested it :-) It works pretty well with a deployment from scratch. I think you can safely merge it. I even fixed some strange minor error, like: https://github.com/rodekruis/shelter-database/blob/master/src/runserver.py#L68 (extra_files is only defined in debug mode). So it can just be 'better'...

I'll send soon (I hope) a second little PR. Just to clean a bit more the deployment.

arongergely commented 6 years ago

Allright, thank you!